Repository navigation
fix: Item::Alias#max_length — rs parity, the 33-row cross-runtime exemption retires (WO17) - #840
Merged
Merged
Conversation
The deterministic parallel sort (megaregexp path) raised NotImplementedError for any non-stdlib alias, erroring whole passes: 33 golden rows across un-ara-Arab-Latn-1971/1972 and the odni-rus Arabic variants carried a standing cross-runtime exemption. The rs runtime - the golden source, at zero deltas - counts every alias as max_length 1 (rs Item::max_length: Prim/Alias => 1, 0 for none), and alias resolution would need document context the sort site does not carry. The ruby runtime now mirrors that. Specs watched failing first: the pinned-to-rs integration row through the megaregexp path, and the unit counts (any alias 1, none 0). Verified: ruby golden gate parity 12,337 rows -> delta 0 (was 33); full suite 409 examples 0 failures; the WO80 capture-in-parallel NoMethodError pin is unaffected (different class, capture stays unsupported in parallel).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item::Alias#max_lengthraisedNotImplementedErrorfor any non-stdlib alias, so whole megaregexp passes errored: 33 golden rows acrossun-ara-Arab-Latn-1971/1972and the odni-rus Arabic variants carried a standing cross-runtime exemption in every golden comparison.The rs runtime — the golden source, at zero deltas — counts every alias as
max_length 1(rs Item::max_length: Prim/Alias => 1, 0 for none); resolving the expansion would need document context the sort site does not carry. The ruby runtime now mirrors that, one branch collapsed.Verification (WO17 step 1)
ruby -Ilib tools/isc_wf1_golden_gate.rb --parity→rows: 12337 ... delta vs golden (cross-runtime): 0— was 33.iscrsrun recorded in the WO17 ledger) and the unit counts (any alias 1,none0).standardrbclean on changed files.max_length) is unaffected — different class, capture stays unsupported in parallel.